Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42826 )
Change subject: gpio_keys: Allows boards to configure different wakeup routes
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42826/1/src/drivers/generic/gpio_ke...
File src/drivers/generic/gpio_keys/chip.h:
https://review.coreboot.org/c/coreboot/+/42826/1/src/drivers/generic/gpio_ke...
PS1, Line 65: unsigned int wake;
Hehe.. I actually thought of that, but got lazy I guess. I will update it.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42826
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib32b866b5f0ca559ed680b46218454bdfd8c6457
Gerrit-Change-Number: 42826
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Jun 2020 08:36:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment