23 Nov
2020
23 Nov
'20
10:59 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46589 )
Change subject: nb/amd/agesa/family15tn: define macro for internal HDMI audio controller ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46589/5/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family15tn/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/46589/5/src/northbridge/amd/agesa/f... PS5, Line 17: #define ACTL_DEVFN PCI_DEVFN(GFX_DEV,ACTL_FUNC)
space required after that ',' (ctx:VxV)
The whole file could be reformatted at once in a separate patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/46589
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic48c7475ceadb60f825ca9e3c3427c8a7525a266
Gerrit-Change-Number: 46589
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Nov 2020 09:59:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Gerrit-MessageType: comment