Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31503 )
Change subject: drivers/intel/gma: Add `new-pch.asl` for Skylake+
......................................................................
Patch Set 1:
(1 comment)
This change looks to require CSTE (Current Display State), NSTE (Next Display State) and DSEN (Display Output Switching Enable) added to globalnvs and the SMI trap added back to platform (https://github.com/coreboot/coreboot/commit/2e37fdddd5f859b82923485612ec8693...)
https://review.coreboot.org/c/coreboot/+/31503/1/src/drivers/intel/gma/acpi/...
File src/drivers/intel/gma/acpi/new-pch.asl:
PS1:
Something like that was the original idea. But people have re-invented […]
Are you referring to CB:32529 and CB:32549?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b21d9a0288f0f8d6cb0a4776909bffdae7576f5
Gerrit-Change-Number: 31503
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Mar 2020 21:12:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-MessageType: comment