[coreboot-gerrit] [M] Change in coreboot[main]: cpu/intel/model_206ax: Only use supported C-states

[Patrick Rudolph (Code Review)]

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78194?usp=email )

Change subject: cpu/intel/model_206ax: Only use supported C-states
......................................................................

cpu/intel/model_206ax: Only use supported C-states

Make sure that the C-state is supported by the CPU.
Downgrade if it's not and make sure to not advertise
duplicate states.

Add debug prints for the finally selected mapping
of ACPI C state vs Intel CPU C state.

Change-Id: Iaaee050e0ce3c29c12e97f5819a29f485a7946c2
Signed-off-by: Patrick Rudolph 
---
M src/cpu/intel/model_206ax/acpi.c
1 file changed, 57 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/78194/1

diff --git a/src/cpu/intel/model_206ax/acpi.c b/src/cpu/intel/model_206ax/acpi.c
index 785fcb9..0273c70 100644
--- a/src/cpu/intel/model_206ax/acpi.c
+++ b/src/cpu/intel/model_206ax/acpi.c
@@ -88,11 +88,36 @@
    printk(BIOS_DEBUG, "Supported C-states: C0 %s\n", str);
 }

+/*
+ * Returns the supported C-state or the next lower one that
+ * is supported.
+ */
+static int get_supported_cstate(int cstate)
+{
+	uint8_t h, l;
+	size_t i;
+
+	assert(cstate < NUM_C_STATES);
+
+	for (i = cstate; i > 0; i--) {
+		h = (cstate_map[i].resource.addrl >> 4) + 1;
+		l = cstate_map[i].resource.addrl & 0xf;
+		if (cpu_get_c_state_support(h) > l)
+			break;
+	}
+
+	if (cstate != i)
+		printk(BIOS_DEBUG, "Requested C-state %s not supported, using %s instead\n",
+		       c_state_names[cstate], c_state_names[i]);
+
+	return i;
+}
+
 static void generate_C_state_entries(const struct device *dev)
 {
    struct cpu_intel_model_206ax_config *conf = dev->chip_info;

-	const int acpi_cstates[3] = { conf->acpi_c1, conf->acpi_c2, conf->acpi_c3 };
+	int acpi_cstates[3] = { conf->acpi_c1, conf->acpi_c2, conf->acpi_c3 };

acpi_cstate_t acpi_cstate_map[ARRAY_SIZE(acpi_cstates)] = { 0 };
    /* Count number of active C-states */
@@ -101,12 +126,39 @@
    print_supported_cstates();

for (int i = 0; i < ARRAY_SIZE(acpi_cstates); i++) {
-		if (acpi_cstates[i] > 0 && acpi_cstates[i] < ARRAY_SIZE(cstate_map)) {
-			acpi_cstate_map[count] = cstate_map[acpi_cstates[i]];
-			acpi_cstate_map[count].ctype = i + 1;
-			count++;
+		/* Remove invalid states */
+		if (acpi_cstates[i] >= ARRAY_SIZE(cstate_map)) {
+			printk(BIOS_ERR, "Invalid C-state in devicetree: %d\n",
+			       acpi_cstates[i]);
+			acpi_cstates[i] = 0;
+			continue;
+		}
+		/* Skip C0, it's always supported */
+		if (acpi_cstates[i] == 0)
+			continue;
+
+		/* Find supported state. Might downgrade a state. */
+		acpi_cstates[i] = get_supported_cstate(acpi_cstates[i]);
+
+		/* Remove duplicate states */
+		for (int j = i - 1; j >= 0; j--) {
+			if (acpi_cstates[i] == acpi_cstates[j]) {
+				acpi_cstates[i] = 0;
+				break;
+			}
    	}
    }
+
+	/* Convert C-state to ACPI C-states */
+	for (int i = 0; i < ARRAY_SIZE(acpi_cstates); i++) {
+		if (acpi_cstates[i] == 0)
+			continue;
+		acpi_cstate_map[count] = cstate_map[acpi_cstates[i]];
+		count++;
+		printk(BIOS_DEBUG, "Advertising ACPI C State type C%d as CPU %s\n",
+		       count, c_state_names[acpi_cstates[i]]);
+	}
+
    acpigen_write_CST_package(acpi_cstate_map, count);
 }