Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37992 )
Change subject: mb/google/slippy: Fix IRQ of the ambient light sensor
......................................................................
Patch Set 1: Code-Review+2
I'd add a note in the commit message as to how the correct IRQ was derived,
and that the ACPI code using this will be added in a follow-up commit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2a8356d261d211d5ed5c0b035c94ec56b9c25b3
Gerrit-Change-Number: 37992
Gerrit-PatchSet: 1
Gerrit-Owner: Nicolò
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nicolò
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 29 Dec 2019 22:36:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment