Attention is currently required from: Furquan Shaikh, Selma Bensaid, Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak, Angel Pons, Subrata Banik, Ronak Kanabar, Patrick Rudolph.
Meera Ravindranath has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51849 )
Change subject: soc/intel/alderlake: Enable VT-d
......................................................................
Patch Set 11:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51849/comment/3106d004_afe158aa
PS3, Line 9: Update UPDs required for enabling VT-d.
What are the default settings?
Ack
https://review.coreboot.org/c/coreboot/+/51849/comment/44dfc9dc_31fc8ade
PS3, Line 10:
Tested how?
Ack
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/51849/comment/ccf7c468_7e3ed199
PS3, Line 197: /* VT-d config */
Please make it a separate commit, and fix it for all SoCs.
Ack
https://review.coreboot.org/c/coreboot/+/51849/comment/3d79af1a_193b4104
PS3, Line 199: m_cfg->VtdIopEnable = 0x1;
Why 0x1 and not just 1?
Ack
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/51849/comment/30c0dc67_4f1703a6
PS4, Line 212: /* Change VmxEnable UPD value according to ENABLE_VMX Kconfig */
also the TBTxBAR(x) BARs as well
Ack
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/51849/comment/7e59c75a_f9a67448
PS10, Line 204:
nit: extra blank line
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I96a9f3df185002a4e58faa910f867ace0b97ec2b
Gerrit-Change-Number: 51849
Gerrit-PatchSet: 11
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 29 Apr 2021 06:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment