[coreboot-gerrit] Change in coreboot[master]: nb/via/vx900: Ensure framebuffer size is within limits

[Jacob Garber (Code Review)]

Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34355 )

Change subject: nb/via/vx900: Ensure framebuffer size is within limits
......................................................................

Patch Set 3:

(3 comments)

https://review.coreboot.org/c/coreboot/+/34355/2/src/northbridge/via/vx900/m... 
File src/northbridge/via/vx900/memmap.c:

https://review.coreboot.org/c/coreboot/+/34355/2/src/northbridge/via/vx900/m... 
PS2, Line 81: 	assert(size_mb != 0);
> This thing needs an #include. […]

Done

https://review.coreboot.org/c/coreboot/+/34355/2/src/northbridge/via/vx900/m... 
PS2, Line 84: 0
> After that assert, you know the first iteration of the loop will always run. […]

Done

https://review.coreboot.org/c/coreboot/+/34355/2/src/northbridge/via/vx900/m... 
PS2, Line 89: 	size_mb = (1U << fb_pow);
> Ack

Done