Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 )
Change subject: Documentation/Intel: s5 charging applet design document ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_... File Documentation/soc/intel/s5_charging_applet/s5_charging_applet.md:
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_... PS4, Line 84: We can display charging screen after graphics PEIM execution has finished after fsp-s.
If we are waiting until FSP-S i.e. […]
I guess we are here dealing with entire PCI enumeration vs not doing PCI enumeration.
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_... PS4, Line 86: charging applet onto screen.
coreboot is about only initializing the necessary hardware, so payloads can start. […]
As long as we are not mandatorily making S5 charging applet implementation for all platform, its not violating the spec. its an option like other bootloader has for modern OS tablet usecase, we have added this feature, if we are not intended to enable this for certain platform, then don't select the required Kconfig but i don't think we can say no to innovation in coreboot space as violation of previous assumptions