[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add memory initialization support for dedede

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39136 )

Change subject: mb/google/dedede: Add memory initialization support for dedede
......................................................................

Patch Set 21:

(2 comments)

https://review.coreboot.org/c/coreboot/+/39136/21/src/mainboard/google/deded... 
File src/mainboard/google/dedede/romstage.c:

https://review.coreboot.org/c/coreboot/+/39136/21/src/mainboard/google/deded... 
PS21, Line 21: mem_cfg
Nit: can just be memupd->FspmConfig

https://review.coreboot.org/c/coreboot/+/39136/21/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39136/21/src/mainboard/google/deded... 
PS21, Line 48: 	/* C0  : RAM_STRAP_0 */
             : 	PAD_CFG_GPI(GPP_C0, NONE, DEEP),
             : 	/* C3  : RAM_STRAP_1 */
             : 	PAD_CFG_GPI(GPP_C3, NONE, DEEP),
             : 	/* C4  : RAM_STRAP_2 */
             : 	PAD_CFG_GPI(GPP_C4, NONE, DEEP),
             : 	/* C5  : RAM_STRAP_3 */
             : 	PAD_CFG_GPI(GPP_C5, NONE, DEEP),
Why do these need to be here? They're already enabled in the early_gpio table.