6 Mar
2023
6 Mar
'23
10:39 a.m.
Attention is currently required from: Robert Zieba, Raul Rangel, Martin L Roth, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69915 )
Change subject: device/xhci: Add struct for capability registers ......................................................................
Patch Set 13: Code-Review+2
(1 comment)
File src/include/device/xhci.h:
https://review.coreboot.org/c/coreboot/+/69915/comment/4c2631af_efa6a479 PS11, Line 109:
even in cases where it doesn't change the layout in memory and isn't required, i tend to use __packe […]
I had asked for __packed and that comment is addressed. I will mark it as resolved. Please re-open the comment if you feel otherwise.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69915
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If38bfde726bd4e5dd314456f25a2b08acd3cd20c
Gerrit-Change-Number: 69915
Gerrit-PatchSet: 13
Gerrit-Owner: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Robert Zieba robertzieba@google.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 06 Mar 2023 17:39:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin L Roth gaumless@gmail.com
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment