Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )
Change subject: fw_config: Add firmware configuration interface
......................................................................
Patch Set 9:
(1 comment)
I did not really review the work here, I just wanted to leave a general (possibly unrelated) comment that linking static.c into SMM is IMHO a bad idea since the copy of devicetree there does not reflect any modifications ramstage could have made.
https://review.coreboot.org/c/coreboot/+/41209/7/src/lib/fw_config.c
File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/41209/7/src/lib/fw_config.c@11
PS7, Line 11: MAYBE_STATIC_BSS bool fw_config_value_initialized;
Hm yes this was supposed to be in a function and it isn't really a migrated global but I had not see […]
Leave comments in CB:40535 please.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e889c235a81545e2ec0e3a34dfa750ac828a330
Gerrit-Change-Number: 41209
Gerrit-PatchSet: 9
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 May 2020 04:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment