4 Dec
2020
4 Dec
'20
2:16 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48263 )
Change subject: cpu/x86/smm_module_loaderv2: Fix compiling for x86_64 ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/48263/3/src/cpu/x86/smm/smm_module_... File src/cpu/x86/smm/smm_module_loaderv2.c:
https://review.coreboot.org/c/coreboot/+/48263/3/src/cpu/x86/smm/smm_module_... PS3, Line 315: params->num_concurrent_save_states, I would have kept the alignment, or reflowed things to use the full 96-char limit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48263
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9288ede88f822ff78dd9cb91020451dc935203a0
Gerrit-Change-Number: 48263
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Dec 2020 14:16:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment