Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43718 )
Change subject: ec/system76: Add console support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43718/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43718/2//COMMIT_MSG@9 PS2, Line 9: This adds support for line-buffered console output to System76 EC firmware.
How does this console work? That is, how would one grab logs from the System76 Ec?
Once the print command is received, the EC firmware multiplexes the output to any enabled console on the EC. This can be a memory ringbuffer, a parallel port (using the keyboard connector), or i2c (using the battery connector). Once the entire buffer is sent, it sets the command register to 0, indicating completion.
Those methods can be seen here: https://github.com/system76/ec/blob/master/src/board/system76/common/stdio.c...