Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30467 )
Change subject: mb/google/hatch: Enable PCIe WLAN and BT
......................................................................
Patch Set 23:
(2 comments)
https://review.coreboot.org/#/c/30467/22//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30467/22//COMMIT_MSG@13
PS22, Line 13: Update mainboard ramstage.c to return correct PCI_DEVFN for WLAN to
: the soc.
This is currently not done.
Removing from commit message. Will push a separate patch for this
https://review.coreboot.org/#/c/30467/22//COMMIT_MSG@19
PS22, Line 19: TEST
Did you get a chance to verify WoWLAN with this change?
No, We have not tested Wake on WLAN with this patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f2a6eb37a467ad8b8cdde8fe6b657fabb383b04
Gerrit-Change-Number: 30467
Gerrit-PatchSet: 23
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Jan 2019 07:08:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment