Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38036 )
Change subject: nb/intel/sandybridge: Add a bunch of MCHBAR defines ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38036/7/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/sandybridge.h:
https://review.coreboot.org/c/coreboot/+/38036/7/src/northbridge/intel/sandy... PS7, Line 220: /* Sub-sequence special command address */ : #define IOSAV_y_SP_CMD_ADDR_Cx(x, y) LyCx(0x4200, x, y) : : /* Address update after command execution */ : #define IOSAV_y_ADDR_UPD_Cx(x, y) LyCx(0x4210, x, y) : : /* Command signals in sub-sequence command */ : #define IOSAV_y_SP_CMD_CTL_Cx(x, y) LyCx(0x4220, x, y) : : /* Sub-sequence command parameter control */ : #define IOSAV_y_SUBSEQ_CTL_Cx(x, y) LyCx(0x4230, x, y) : : /* 23-bit LFSR value of the sequence */ : #define IOSAV_y_ADDRESS_LFSR_Cx(x, y) LyCx(0x4240, x, y)
These are inverted for reproducibility purposes. […]
I'd keep CxLy instead. but let's keep it like it is for not and change/fix that in a follow-up patch. a comment at the declaration of the two macros would be good though