Attention is currently required from: Jakub Czapiga, Marek Maślanka, Michał Żygowski.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )
Change subject: soc/intel/common/block: Add support for watchdog ......................................................................
Patch Set 15:
(2 comments)
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/dc51913e_220f73d9 : PS13, Line 396: rightmost_bit_offset
thanks, the `__builtin_ctzll` is doing what I needed.
Acknowledged
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/79909/comment/0b49d1c7_9f422631 : PS14, Line 408: tcobase
every usage of `tco_get_bar()` assumes it's already programmed, but in case if it isn't performed yet it doesn't hurt to go forward
what if in future we have some other caller for fill_wdat_timeout_entry() function do you expect that every caller will do the needful check of `tcobar` before calling to fill_wdat_timeout_entry()?