Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email )
Change subject: Add MTCL function to ACPI SSDT tables
......................................................................
Patch Set 6:
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/80170/comment/c7c4ae6b_36a6d1d2 :
PS6, Line 1968: acpigen_write_byte(bytes[i]);
Is this valid AML? I would expect a Buffer() object around the bytes. […]
Looking into the kernel code (which looks crazy btw.) it seems to expect
individual integers (bails out if `sar_unit->type != ACPI_TYPE_INTEGER`,
doesn't check the number of bytes read). So we might have to prefix every
single byte with a BYTE_OP?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80170?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350
Gerrit-Change-Number: 80170
Gerrit-PatchSet: 6
Gerrit-Owner: David Ruth
druth@chromium.org
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: David Ruth
druth@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Comment-Date: Wed, 24 Jan 2024 13:05:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment