Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47492 )
Change subject: nb/intel/sandybridge: Use arrays to program IOSAV ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_iosav.c:
https://review.coreboot.org/c/coreboot/+/47492/1/src/northbridge/intel/sandy... PS1, Line 32: ssq_count
I specifically want to remove this assignment. A sequence doesn't get destroyed after executing it, so it can be run multiple times. Then, the only time ssq_count would be zero is if one tries to execute a sequence before programming any of the subsequence registers.
That makes sense. Thanks for clarifying.