Rishabh Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33425 )
Change subject: qcs405: Add support for specifying mbn_version ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33425/4/util/qualcomm/mbn_tools.py File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/#/c/33425/4/util/qualcomm/mbn_tools.py@73 PS4, Line 73: MI_BOOT_IMG_HDR_SIZE_v6 = 48 # sizeof(mi_boot_image_header_type) for v6 header
I think both of these constants are unused not and can be removed. […]
Done
https://review.coreboot.org/#/c/33425/4/util/qualcomm/mbn_tools.py@76 PS4, Line 76: VERSION_6 = 6 # Mbn header_version 6
These constants seem kinda pointless, and you're mostly not using them anyway.
in new patch all version 3,5 and 6 will use these constants