Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45221 )
Change subject: xeon_sp: De-duplicate .h files
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45221/2/src/soc/intel/xeon_sp/skx/i...
File src/soc/intel/xeon_sp/skx/include/soc/irq.h:
PS2:
The CPX header is GPL-2.0-only, maybe keep this one instead?
https://review.coreboot.org/c/coreboot/+/45221/2/src/soc/intel/xeon_sp/skx/i...
File src/soc/intel/xeon_sp/skx/include/soc/msr.h:
https://review.coreboot.org/c/coreboot/+/45221/2/src/soc/intel/xeon_sp/skx/i...
PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
The CPX header is GPL-2.0-only, maybe keep this one instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11d8a95a4b2f9451615b236798b3bd030c724858
Gerrit-Change-Number: 45221
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 11 Sep 2020 09:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment