Hello build bot (Jenkins), Raul Rangel, Patrick Georgi, Martin Roth, Paul Menzel, Angel Pons, Magf -,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40247
to look at the new patch set (#5).
Change subject: soc/amd/picasso/i2c: don't initialize I2C4 as master and refactor code ......................................................................
soc/amd/picasso/i2c: don't initialize I2C4 as master and refactor code
I2C0&1 are either not available or not functional. Add place holders instead, so that the array index matches the I2C controller number. I2C4 is slave device only, so do not initialize it as I2C host controller. Also do some slight refactoring.
BUG=b:153152871 BUG=b:153675916
Change-Id: I397b074ef9c14bf6a4f6680696582f5173a5d0d3 Signed-off-by: Martin Roth martinroth@chromium.org Signed-off-by: Paul Ma magf@bitland.corp-partner.google.com Signed-off-by: Raul E Rangel rrangel@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1897071 Reviewed-on: https://chromium-review.googlesource.com/2057468 Reviewed-on: https://chromium-review.googlesource.com/2094855 Reviewed-on: https://chromium-review.googlesource.com/2149870 --- M src/soc/amd/common/block/lpc/lpc.c M src/soc/amd/picasso/chip.h M src/soc/amd/picasso/i2c.c M src/soc/amd/picasso/include/soc/iomap.h 4 files changed, 29 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40247/5