Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37783 )
Change subject: soc/intel/tigerlake: Update chip files ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37783/7/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/37783/7/src/soc/intel/tigerlake/chi... PS7, Line 56: break;
needs one more indentantion level.
Ack
https://review.coreboot.org/c/coreboot/+/37783/7/src/soc/intel/tigerlake/chi... PS7, Line 68: }
please put parentheses on the same level as the statement opening it.
Ack
https://review.coreboot.org/c/coreboot/+/37783/7/src/soc/intel/tigerlake/chi... PS7, Line 82: case PCH_DEVFN_I2C4: return "I2C4"; Need I2C5