Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44209 )
Change subject: soc/samsung: Add missing <commonlib/helpers.h>
......................................................................
Patch Set 1:
Patch Set 1:
I would prefer we always include <types.h> for this sort of stuff. commonlib is an implementation detail, we shouldn't have that complicated web of header directories reflected in every source file.
Do you mean relocating definitions from commonlib/bsd/helpers.h or including commonlib/helpers.h through types.h ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If506786c80644e12549798ce5f7f6f5b8e4af348
Gerrit-Change-Number: 44209
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 05 Aug 2020 22:10:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment