Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46259 )
Change subject: intel/common/pmc: Add functions for IPC mailbox in ACPI ......................................................................
Patch Set 10:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46259/10/src/soc/intel/common/block... File src/soc/intel/common/block/pmc/pmc_ipc.c:
https://review.coreboot.org/c/coreboot/+/46259/10/src/soc/intel/common/block... PS10, Line 112: FIELDLIST_NAMESTR("IWB3", 32), /* Write Buffer 3 */
I wonder if the results contained in the read buffer are ever worth keeping around? I see they weren […]
I started by thinking a read function would be separate, but it would end up with a lot of duplicated code so I guess I might as well do it in here.
https://review.coreboot.org/c/coreboot/+/46259/10/src/soc/intel/common/block... PS10, Line 164: Local0
Local1
Done
https://review.coreboot.org/c/coreboot/+/46259/10/src/soc/intel/common/block... PS10, Line 172: 0
Should this be a #define in the . […]
Ya I can do that. The current RTD3 use case ignores the return value since there isn't much it can do about it but it might as well make it available.
https://review.coreboot.org/c/coreboot/+/46259/10/src/soc/intel/common/block... PS10, Line 181: Local0
Local1
Done
https://review.coreboot.org/c/coreboot/+/46259/10/src/soc/intel/common/block... PS10, Line 215: acpigen_write_integer
acpigen_write_dword? probably doesn't matter, it does know the write buffer fields are 32 bits wide.
Done