Attention is currently required from: Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 )
Change subject: Adding new ITE IT8987e ......................................................................
Patch Set 1:
(32 comments)
File src/superio/ite/it8987e/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/e4f48a5b_d3a97edc PS1, Line 18: if (!dev->enabled) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/973b18f7_e5eedb82 PS1, Line 18: if (!dev->enabled) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/5d7ee3a2_523495d9 PS1, Line 19: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/575319c0_2f7ac79b PS1, Line 19: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/b98e465c_2a29b956 PS1, Line 21: switch (dev->path.pnp.device) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/1850e995_730afdd4 PS1, Line 21: switch (dev->path.pnp.device) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/408a1f32_6562f98d PS1, Line 22: case IT8987E_KBCK: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/8ca950e9_bd52c4c5 PS1, Line 22: case IT8987E_KBCK: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/cf91b8a1_8154e961 PS1, Line 23: pc_keyboard_init(NO_AUX_DEVICE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/8408dbc5_1c8e9168 PS1, Line 23: pc_keyboard_init(NO_AUX_DEVICE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/4d01137d_1476a91b PS1, Line 24: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/39539a94_6b6fdd94 PS1, Line 24: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/10b85c11_283b1608 PS1, Line 25: default: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/01b45fe1_9ae04e54 PS1, Line 27: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/19166a5c_1219e2d7 PS1, Line 27: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/9658ccb1_e51d780d PS1, Line 28: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/19981cfe_c9ee4e6e PS1, Line 28: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/68e55a46_86d60174 PS1, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/5cbe22a8_2495188b PS1, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/af9482ae_9493e876 PS1, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/90428ac2_be150b76 PS1, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/28cdd618_834db09a PS1, Line 65: const struct superio_ite_it8987e_config *conf; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/8cf9e530_b004b6ca PS1, Line 65: const struct superio_ite_it8987e_config *conf; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/7e992ba4_16be3e55 PS1, Line 69: conf = dev->chip_info; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/de720446_a2f7ca2b PS1, Line 69: conf = dev->chip_info; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/efd56675_b0511ad2 PS1, Line 70: if (!conf) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/d9ccf847_e544292e PS1, Line 70: if (!conf) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/07f89e41_8fd21c34 PS1, Line 70: if (!conf) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/c5c72b4a_cb788c0a PS1, Line 74: printk(BIOS_INFO, "IT8987E: init ITE EC\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/7110d470_f0adb278 PS1, Line 75: ite_ec_init(0x25e, &conf->ec); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/a72ab840_3e683578 PS1, Line 75: ite_ec_init(0x25e, &conf->ec); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169931): https://review.coreboot.org/c/coreboot/+/72827/comment/1b2f21cd_9b9f460e PS1, Line 75: ite_ec_init(0x25e, &conf->ec); please, no spaces at the start of a line