Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42242 )
Change subject: drivers/ocp/ipmi: Add ipmi set processor information ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42242/1/src/drivers/ocp/ipmi/ipmi_o... File src/drivers/ocp/ipmi/ipmi_ocp.c:
https://review.coreboot.org/c/coreboot/+/42242/1/src/drivers/ocp/ipmi/ipmi_o... PS1, Line 63: for (int index = 0; index < sizeof(req1.data.manufacturer_id); index++) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/c/coreboot/+/42242/1/src/drivers/ocp/ipmi/ipmi_o... PS1, Line 98: for (int index = 0; index < sizeof(req2.data.manufacturer_id); index++) {
braces {} are not necessary for single statement blocks
Done
https://review.coreboot.org/c/coreboot/+/42242/1/src/drivers/ocp/ipmi/ipmi_o... PS1, Line 150: if (ipmi_set_processor_information_param1(dev)) {
braces {} are not necessary for single statement blocks
Done