[coreboot-gerrit] Change in coreboot[master]: commonlib/bsd: Add new CBFS core implementation

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )

Change subject: commonlib/bsd: Add new CBFS core implementation
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_pri... 
File src/commonlib/bsd/cbfs_private.c:

https://review.coreboot.org/c/coreboot/+/38421/11/src/commonlib/bsd/cbfs_pri... 
PS11, Line 75: 				  offset + sizeof(mdata.h), todo) != todo)
> Right, for Chrome OS specifically, I see no way this could cause a problem that wouldn't immediately […]

Why not use an assert() here? I've decided to use assertions when I've already verified the condition, but not nearby (e.g. in different files).

For example, I ensure the value for tWR can be programmed into the DDR3 MR0 (Mode Register 0) when computing the timings to use, but the code that programs the MR0 is on a different file.