Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44302 )
Change subject: mb/lenovo/thinkcentre_m91p add ThinkCentre M91p ......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... File src/mainboard/lenovo/thinkcentre_m91p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... PS5, Line 16: device domain 0x0 on
Since the subsystem ID is the same everywhere, you can remove all `subsystemid` lines and put this h […]
Done
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... PS5, Line 20: end
This is part of the comment (comments begin with `#` in the devicetree), so it most likely doesn't b […]
should be on
https://review.coreboot.org/c/coreboot/+/44302/5/src/mainboard/lenovo/thinkc... PS5, Line 45: device pci 1c.0 off # PCIe Port #1 end
We need to keep unused root ports here, otherwise they will be enabled. According to schematics: […]
Done