Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34447 )
Change subject: soc/intel/common: Set controller state to active in uart init
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34447/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34447/3/src/soc/intel/common/block/...
PS3, Line 87: uart_lpss_init(baseaddr, device);
uart_lpss_init(device, baseaddr);
https://review.coreboot.org/c/coreboot/+/34447/3/src/soc/intel/common/block/...
PS3, Line 230: uart_lpss_init(base, dev)
uart_lpss_init(dev, base);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0187267670e1dea3e1d5e83d0b29967724d6063e
Gerrit-Change-Number: 34447
Gerrit-PatchSet: 3
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 19 Jul 2019 10:32:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment