Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp...
PS3, Line 17: #include <intelblocks/lpss.h>
Is this include required related to other modification? […]
No, This was required for the build to go through soc_lpss_controllers_list is declared in common soc block
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37556
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b2c82fc7592120993bc483d3061803cf75c7335
Gerrit-Change-Number: 37556
Gerrit-PatchSet: 3
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Dec 2019 09:07:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment