Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41586 )
Change subject: drivers/vpd: rename VPD_ANY to VPD_RO_OR_RW
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41586/3/src/drivers/vpd/vpd.c
File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/41586/3/src/drivers/vpd/vpd.c@179
PS3, Line 179: consumed = 0;
This is all... getting pretty hairy. […]
I was going to add the same comment - please rebase to jwerner's patch.
And yes, I have gave almost the same feedback (and similar implementation) in the follow up change...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41586
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I960688d1f6ab199768107ab73b8a7400a3fdf473
Gerrit-Change-Number: 41586
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 02:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment