Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30844 )
Change subject: string.h: allow to compile strdup in romstage
......................................................................
Patch Set 4:
Again, I wanna plug using the dead_code() macro for this. It would lead to a message like:
src/include/assert.h:57:2: error: call to 'dead_code_assertion_failed_57' declared with attribute error: "strdup() must not be used in romstage!" in src/include/string.h:24
when you try to build it the wrong way, and it would also make it clear to anyone reading the strdup() code that this is intentional.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30844
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85738a7c7c2f4b0be9b1624b34c478ecdfbb25ed
Gerrit-Change-Number: 30844
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Thu, 17 Jan 2019 21:41:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment