[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Add custom SAR values for Foob360

[Peichao Li (Code Review)]

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39424 )

Change subject: mb/google/octopus: Add custom SAR values for Foob360
......................................................................

Patch Set 11:

(3 comments)

https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h:

https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... 
PS9, Line 39: uint32_t get_board_sku(void);
> No need to re-introduce this function.

Done

https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/foob/mainboard.c:

https://review.coreboot.org/c/coreboot/+/39424/6/src/mainboard/google/octopu... 
PS6, Line 24: 	uint32_t sku_id = google_chromeec_get_board_sku();
> @Marco, I found that the function: get_board_sku() actually still uses the function: google_chromeec […]

Done

https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/foob/variant.c:

https://review.coreboot.org/c/coreboot/+/39424/9/src/mainboard/google/octopu... 
PS9, Line 55: 	uint32_t sku_id = get_board_sku();
> Please use google_chromeec_get_board_sku() like in line 34 instead of get_board_sku().

Done