Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33773 )
Change subject: sb/amd/rs780: Remove dead assignment ......................................................................
sb/amd/rs780: Remove dead assignment
We return immediately after, so this assignment can be removed.
Change-Id: I2a317ada0132a40b623402055b3b995bde80ddf5 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: scan-build 8.0.0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33773 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/amd/rs780/cmn.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/amd/rs780/cmn.c b/src/southbridge/amd/rs780/cmn.c index 17ca980..1520748 100644 --- a/src/southbridge/amd/rs780/cmn.c +++ b/src/southbridge/amd/rs780/cmn.c @@ -263,7 +263,6 @@ gfx_gpp_sb_sel = PCIE_CORE_INDEX_GPP; break; default: - gfx_gpp_sb_sel = -1; return 0; }