Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34709 )
Change subject: x86: Prevent Kconfig errors resulting in a brick
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG@9
PS1, Line 9: Always select USE_LEGACY_8254_TIMER if we know we have to.
Better use that information as the commit message summary?
https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG@11
PS1, Line 11: Linux kernel/GRUB2
payload?
https://review.coreboot.org/c/coreboot/+/34709/1//COMMIT_MSG@13
PS1, Line 13:
Mention the commit breaking this in a Fixes: line?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34709
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica0c20255f661dd61edc3a7d15646b7447c4658e
Gerrit-Change-Number: 34709
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 05 Aug 2019 16:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment