Attention is currently required from: Johnny Lin, Stefan Reinauer, Arthur Heymans.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55071 )
Change subject: cpu/x86/mp_init: Fix false error message on parking APs twice
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Why not fix the spurious call instead?
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/55071/comment/fc45e2b7_585883f0
PS2, Line 1056: printk(BIOS_DEBUG, "%s: CPUs already parked\n", __func__);
We know they had been, but what if they aren't anymore?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60095cffcb9b31d965b0525ddc3018b592a3e52e
Gerrit-Change-Number: 55071
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 07 Sep 2021 08:20:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment