Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39460 )
Change subject: tgl boards: Configure retimer Aux orientation
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39460/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39460/4/src/mainboard/google/voltee...
PS4, Line 130: register "TcssAuxOri" = "0"
Great, thanks. […]
From my knowledge of setting this the GPIO takes care of the resume case. Since this setting is set every time FSPS is ran there shouldn't be an issue coming out of S5. I find it strange that the FSP setting would get reset on S3 resume, I'm still looking into this some more as to the lock bit being set once I have that information I will share what needs to be done for that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29eb0513299126ad8d1ee11ded2c771f28ad13f3
Gerrit-Change-Number: 39460
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-CC: Prashant Malani
pmalani@chromium.org
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Fri, 27 Mar 2020 17:23:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment