[coreboot-gerrit] Change in coreboot[master]: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro

[Werner Zeh (Code Review)]

Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )

Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h 
File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 
PS3, Line 44: #define CURRENT_DSDT_REV	0x02        /* DSDT revision: ACPI v2.0 and greater */
> used values are 1 or 2 (or grater, but same as 2) […]

I just had a short look at ACPI specs v3.0, 4.0, 5.0 and 6.3 (current one). It looks like the revision of DSDT is fixed to 2 since at least ACPI version 3.0. This text can be found in the spec for the revision:
"2. This field also sets the global integer width for the AML 
interpreter. Values less than two will cause the interpreter to use 
32-bit integers and math. Values of two and greater will cause the 
interpreter to use full 64-bit integers and math."

Which explains the 64 bit comment in the mainboards.

Sorry for being bad prepared and yes, your suggested defines would be fine for me.