Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42399 )
Change subject: mb/asrock/b85m_pro4: Expand Super I/O comments
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42399/10/src/mainboard/asrock/b85m_...
File src/mainboard/asrock/b85m_pro4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42399/10/src/mainboard/asrock/b85m_...
PS10, Line 103: irq 0x30 = 0xe1 # + Fan RPM sense pins
On that particular SIO, it also works to select where fan RPM sense pins are located
eww. did you check if this results in the right value ending up the the register?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42399
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03ca67d748725283ba8382e476d70eb5554f5fb8
Gerrit-Change-Number: 42399
Gerrit-PatchSet: 10
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jul 2020 00:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment