Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40335 )
Change subject: device: Add provision for multiple PCI segments
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40335/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/40335/5/src/soc/intel/common/block/...
PS5, Line 43: seg_nr = pciex_bus / 256;
_SEG is an object in the DSDT below the PCI root. Currently, we have […]
Ack
https://review.coreboot.org/c/coreboot/+/40335/5/src/soc/intel/common/block/...
PS5, Line 46: acpi_create_mcfg_mmconfig((void *)current,
: CONFIG_MMCONF_BASE_ADDRESS, seg_nr, 0, bus_end_nr);
acpi_create_mcfg_mmconfig() is supposed to be called once for each segment […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90660c5cfd8af5bb40e36bb409e534541c786cae
Gerrit-Change-Number: 40335
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 03 May 2020 07:43:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment