Attention is currently required from: Kapil Porwal, Nick Vaccaro, SH Kim.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80325?usp=email )
Change subject: mb/google/brya/var/xol: Update GPIO configurations
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brya/variants/xol/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/80325/comment/fd4c42f8_bcb215f4 :
PS1, Line 4: romstage-y += gpio.c
remove too.
File src/mainboard/google/brya/variants/xol/gpio.c:
https://review.coreboot.org/c/coreboot/+/80325/comment/4d59c987_aaa4a060 :
PS1, Line 211: const struct pad_config *variant_romstage_gpio_table(size_t *num)
you can remove if nothing to override.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80325?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I224e58628e44571c07ce034136d690587e62be08
Gerrit-Change-Number: 80325
Gerrit-PatchSet: 1
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 02 Feb 2024 06:20:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment