Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47598 )
Change subject: arch/x86: Remove ID_SECTION_OFFSET
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47598/3/src/arch/ppc64/Kconfig
File src/arch/ppc64/Kconfig:
https://review.coreboot.org/c/coreboot/+/47598/3/src/arch/ppc64/Kconfig@21
PS3, Line 21: config ID_SECTION_OFFSET
: hex
: default 0x80
Weird. […]
It was just defined 0 and nobody used the reverse offsets.
https://review.coreboot.org/c/coreboot/+/47598/2/src/cpu/x86/16bit/reset16.l...
File src/cpu/x86/16bit/reset16.ld:
https://review.coreboot.org/c/coreboot/+/47598/2/src/cpu/x86/16bit/reset16.l...
PS2, Line 27: ID_SECTION = 0xffffff80 - SIZEOF(.id);
Just an unresolved comment, I am redoing some of this.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8348f2ac0cab969ab78ecb50a55de486eee0cf9b
Gerrit-Change-Number: 47598
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 20:38:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment