Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37783 )
Change subject: soc/intel/tigerlake: Update chip files
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch...
File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch...
PS22, Line 135: /* Need to update DLL setting to get Emmc running at HS400 speed */
: uint8_t EmmcUseCustomDlls;
: uint32_t EmmcTxCmdDelayRegValue;
: uint32_t EmmcTxDataDelay1RegValue;
: uint32_t EmmcTxDataDelay2RegValue;
: uint32_t EmmcRxCmdDataDelay1RegValue;
: uint32_t EmmcRxCmdDataDelay2RegValue;
: uint32_t EmmcRxStrobeDelayRegValue;
This is not added but it just keep the chip. […]
Yes, we can use the DLL params from soc_intel_common. We will need just need EmmcUseCustomDlls config for jsl here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1518a7ffa69079fe82232afe229d9e1ffe29067
Gerrit-Change-Number: 37783
Gerrit-PatchSet: 22
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jan 2020 10:48:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment