Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38422 )
Change subject: cbfs: Hook up to new CBFS implementation
......................................................................
Patch Set 17:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38422/17/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/38422/17/src/lib/cbfs.c@41
PS17, Line 41: (uintptr_t)&fh->mdata, msize) ||
Did you happen to see any users assuming metadata was chained to boot_device ?
No. Nothing outside of commonlib/cbfs.c ever really touches the metadata directly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38422
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d112d1239475920de2d872dac179c245275038d
Gerrit-Change-Number: 38422
Gerrit-PatchSet: 17
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 22 Oct 2020 02:00:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment