Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32651 )
Change subject: soc/amd/stoneyridge: Move GPIO support to common
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32651/5/src/soc/amd/common/block/include/amd...
File src/soc/amd/common/block/include/amdblocks/gpio.h:
https://review.coreboot.org/#/c/32651/5/src/soc/amd/common/block/include/amd...
PS5, Line 304: void soc_get_gpio_event_table(const struct soc_amd_event **table, size_t *items);
No longer an error, right? Or at this point is it easier to shorten the line?
No, this is fine at this point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9cda00210a74de2bd1308ad43e2b867d24a67845
Gerrit-Change-Number: 32651
Gerrit-PatchSet: 5
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 05 Jun 2019 14:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment