Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42242 )
Change subject: drivers/ocp/ipmi: Add ipmi set processor information
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Has populating this a noticeable impact on the boot time?
https://review.coreboot.org/c/coreboot/+/42242/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42242/5//COMMIT_MSG@2
PS5, Line 2: TimChu
Could you please add a space: Tim Chu.
$ git config --global user.name "Tim Chu"
$ git commit --amend --author="Tim Chu Tim.Chu@quantatw.com"
https://review.coreboot.org/c/coreboot/+/42242/5//COMMIT_MSG@23
PS5, Line 23: TimChu
Tim Chu
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42242
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d53ac241a11ca962572816283a0c653fcde9f9e
Gerrit-Change-Number: 42242
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jun 2020 09:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment