Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35348 )
Change subject: Rangeley: Fix incorrect BCLK
......................................................................
Patch Set 7:
(1 comment)
BCLK is also a reference frequency to udelay(), fixing ACPI alone is not enough.
So get_core_fre
https://review.coreboot.org/c/coreboot/+/35348/7/src/cpu/intel/fsp_model_406...
File src/cpu/intel/fsp_model_406dx/acpi.c:
https://review.coreboot.org/c/coreboot/+/35348/7/src/cpu/intel/fsp_model_406...
PS7, Line 157: static int get_core_frequency_mhz(int ratio)
We need to fix cpu/intel/common/fsb.c get_fsb() instead as different BCLK also affects udelay() implementation in coreboot proper. This acpi code should then call get_ia32_fsb() or get_ia32_fsb_x3().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35348
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id8e0244fab0283b74870950cb00a95aab2a7201f
Gerrit-Change-Number: 35348
Gerrit-PatchSet: 7
Gerrit-Owner: hannah.williams@dell.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hannah.williams@dell.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 12 Sep 2019 17:20:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment