Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46394 )
Change subject: mb/google/asurada: change EC SPI to 3M ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46394/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46394/4//COMMIT_MSG@9 PS4, Line 9: To prevent timeout on long EC packet,
Where does it time out?
@yidi, please try this:
mb/google/asurada: fix timeout on EC commands
The Asurada EC is using large packet (256B) mode, and we were seeing lots of time out error on various commands.
The AcceptTimeoutUs in EC SPI driver is hard-coded at 5000, and that is too small for large packet running in 1M so we should change EC SPI to the same value that kernel is using (3M).
https://review.coreboot.org/c/coreboot/+/46394/4//COMMIT_MSG@16 PS4, Line 16:
Missing Signed-off-by line.
Done