Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30800 )
Change subject: southbridge/intel/common/smbus.c: Add support for I2C block write
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/#/c/30800/13/src/southbridge/intel/common/smbus....
File src/southbridge/intel/common/smbus.c:
https://review.coreboot.org/#/c/30800/13/src/southbridge/intel/common/smbus....
PS13, Line 415:
all other functions in this file expect "smbus_base" as argument. Should the HOSTC I2C_EN moved out if this function to have a similar function prototype?
https://review.coreboot.org/#/c/30800/13/src/southbridge/intel/common/smbus....
PS13, Line 437: status = do_i2c_block_write((unsigned int)reg, device, cmd, bytes,
cast not needed
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40f8c0f5257a62398189f36892b8159052481693
Gerrit-Change-Number: 30800
Gerrit-PatchSet: 13
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Apr 2019 12:59:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
