Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32297 )
Change subject: soc/intel/cannonlake: Enable PlatformDebugConsent by Kconfig ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/Kconfig File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/Kconfig@293 PS2, Line 293: bool "Support USB DBC for Cannonlake" Please explain in a help text what this is and how to use it.
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/32297/2/src/soc/intel/cannonlake/romstage/fs... PS2, Line 119: m_cfg->PlatformDebugConsent = config->DebugConsent; Please no competing options in Kconfig and `chip.h`. I guess you can remove the one from `chip.h`? why would we ever want to set this in the devicetree?